Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2AD299AEB for ; Mon, 5 Mar 2012 11:36:20 +0000 (UTC) Received: (qmail 91567 invoked by uid 500); 5 Mar 2012 11:36:18 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 91477 invoked by uid 500); 5 Mar 2012 11:36:18 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 91443 invoked by uid 99); 5 Mar 2012 11:36:18 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Mar 2012 11:36:18 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Mar 2012 11:36:17 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 2D3A09EF3 for ; Mon, 5 Mar 2012 11:35:57 +0000 (UTC) Date: Mon, 5 Mar 2012 11:35:57 +0000 (UTC) From: "Emmanuel Bourg (Resolved) (JIRA)" To: issues@commons.apache.org Message-ID: <844437434.22013.1330947357186.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <993578572.29870.1326289179312.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Resolved] (SANDBOX-357) in CSVPrinter a null check is missing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SANDBOX-357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emmanuel Bourg resolved SANDBOX-357. ------------------------------------ Resolution: Duplicate > in CSVPrinter a null check is missing > ------------------------------------- > > Key: SANDBOX-357 > URL: https://issues.apache.org/jira/browse/SANDBOX-357 > Project: Commons Sandbox > Issue Type: Bug > Components: CSV > Reporter: Odelya > > In CSVPrinter, there is the print method: > public void print(String value) { > boolean quote = false; > if (value.length() > 0) { > char c = value.charAt(0); > if (newLine > && (c < '0' > you should do null check as well before the if (value.length) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira