Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C859D9248 for ; Fri, 30 Mar 2012 01:21:50 +0000 (UTC) Received: (qmail 1039 invoked by uid 500); 30 Mar 2012 01:21:50 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 978 invoked by uid 500); 30 Mar 2012 01:21:50 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 970 invoked by uid 99); 30 Mar 2012 01:21:50 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Mar 2012 01:21:50 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Mar 2012 01:21:48 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 03C8A34E8C0 for ; Fri, 30 Mar 2012 01:21:27 +0000 (UTC) Date: Fri, 30 Mar 2012 01:21:27 +0000 (UTC) From: "Sebb (Resolved) (JIRA)" To: issues@commons.apache.org Message-ID: <74905192.36131.1333070487017.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1125499437.25409.1331917426164.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Resolved] (CSV-70) Improve readability of CSVLexer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CSV-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebb resolved CSV-70. --------------------- Resolution: Fixed I think this is now complete. > Improve readability of CSVLexer > ------------------------------- > > Key: CSV-70 > URL: https://issues.apache.org/jira/browse/CSV-70 > Project: Commons CSV > Issue Type: Improvement > Components: Parser > Affects Versions: 1.0 > Reporter: Benedikt Ritter > Fix For: 1.0 > > > There are several things that can be improved in the token lexer (this has also been discussed on ML, see http://markmail.org/thread/c6x5ji4v44nx5k4h): > * Remove Token input parameter in nextToken() (x) this makes lexer slower > * Add convenience methods isDelimiter(c) and isEncapsulator(c) (/) > * Remove current caracter input parameter from methods (/) > * If possible: replace while(true) loops -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira