Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Mon, 26 Mar 2012 01:30:28 +0000 (UTC)
From: "Sebb (Issue Comment Edited) (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <720926756.15720.1332725428109.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1125499437.25409.1331917426164.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Issue Comment Edited] (CSV-70) Improve readability of
 CSVLexer
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CSV-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238039#comment-13238039 ] 

Sebb edited comment on CSV-70 at 3/26/12 1:29 AM:
--------------------------------------------------

Yes, I tried something similar and it broke the tests.

I think it would be useful to provide (optional) access to the comment fields so one way to solve this would be to return the comment as a token, and deal with it at the record level.
                
      was (Author: sebb@apache.org):
    Yes, I tried something similar and it broke the tests.

I think it would be useful to provide (optional) access to the comment fields so one way to solve this would be to return the comment as a token, and deal will it at the record level.
                  
> Improve readability of CSVLexer
> -------------------------------
>
>                 Key: CSV-70
>                 URL: https://issues.apache.org/jira/browse/CSV-70
>             Project: Commons CSV
>          Issue Type: Improvement
>          Components: Parser
>    Affects Versions: 1.0
>            Reporter: Benedikt Ritter
>             Fix For: 1.0
>
>
> There are several things that can be improved in the token lexer (this has also been discussed on ML, see http://markmail.org/thread/c6x5ji4v44nx5k4h):
> * Remove Token input parameter in nextToken()
> * Add convenience methods isDelimiter(c) and isEncapsulator(c)
> * Remove current caracter input parameter from methods
> * If possible: replace while(true) loops

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira