Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3C58C9237 for ; Tue, 27 Mar 2012 20:54:53 +0000 (UTC) Received: (qmail 69529 invoked by uid 500); 27 Mar 2012 20:54:51 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 69448 invoked by uid 500); 27 Mar 2012 20:54:51 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 69414 invoked by uid 99); 27 Mar 2012 20:54:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Mar 2012 20:54:51 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Mar 2012 20:54:49 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 50B48349A70 for ; Tue, 27 Mar 2012 20:54:28 +0000 (UTC) Date: Tue, 27 Mar 2012 20:54:28 +0000 (UTC) From: "Claudio Squarcella (Commented) (JIRA)" To: issues@commons.apache.org Message-ID: <327700205.25634.1332881668332.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <160526106.15347.1332711748682.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (SANDBOX-416) Improve DFS/BFS visit detecting multiple states and related actions instead of just stop/continue MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SANDBOX-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239942#comment-13239942 ] Claudio Squarcella commented on SANDBOX-416: -------------------------------------------- Hi Simone, I just committed the proposed change. Now {{ABORT}} is available also for the two methods {{discoveryEdge}} and {{discoveryVertex}}. Please see [r1306016|http://svn.apache.org/viewvc?view=revision&revision=1306016]. If it looks good I guess we can close the issue. Cheers :) Claudio > Improve DFS/BFS visit detecting multiple states and related actions instead of just stop/continue > ------------------------------------------------------------------------------------------------- > > Key: SANDBOX-416 > URL: https://issues.apache.org/jira/browse/SANDBOX-416 > Project: Commons Sandbox > Issue Type: Improvement > Components: Graph > Reporter: Simone Tripodi > Assignee: Claudio Squarcella > > As discussed in [ML|http://mail-archives.apache.org/mod_mbox/commons-dev/201203.mbox/%3CCAAqLGLOhZYC8qvT4TLugsnqCgw9BQ-%2BkYoGXVrKASy7PDZdeoQ%40mail.gmail.com%3E], {{org.apache.commons.graph.visit.GraphVisitHandler}} methods that return {{boolean}} flags can be sometimes not so intuitive. > The proposal is replacing {{boolean}} flags return statements with an enumeration values {{ABORT}}, {{CONTINUE}}, {{SKIP}} to identify > * visit has to be immediately terminated > * visit can continue; > * current node children visit can be skipped. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira