Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8010E9BC2 for ; Sat, 17 Mar 2012 19:14:00 +0000 (UTC) Received: (qmail 11590 invoked by uid 500); 17 Mar 2012 19:14:00 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 11520 invoked by uid 500); 17 Mar 2012 19:14:00 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 11510 invoked by uid 99); 17 Mar 2012 19:14:00 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 17 Mar 2012 19:14:00 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 17 Mar 2012 19:13:58 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 205D625894 for ; Sat, 17 Mar 2012 19:13:37 +0000 (UTC) Date: Sat, 17 Mar 2012 19:13:37 +0000 (UTC) From: "Sebb (Commented) (JIRA)" To: issues@commons.apache.org Message-ID: <1932312102.28426.1332011617133.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1620718010.16115.1331763520191.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (CONFIGURATION-486) BeanHelper.setDefaultBeanFactory() is thread-hostile and not thread-safe MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CONFIGURATION-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232049#comment-13232049 ] Sebb commented on CONFIGURATION-486: ------------------------------------ HierarchicalConfiguration.defaultExpressionEngine > BeanHelper.setDefaultBeanFactory() is thread-hostile and not thread-safe > ------------------------------------------------------------------------ > > Key: CONFIGURATION-486 > URL: https://issues.apache.org/jira/browse/CONFIGURATION-486 > Project: Commons Configuration > Issue Type: Bug > Reporter: Sebb > > BeanHelper.setDefaultBeanFactory() sets a private static field. > This is thread-hostile, because different threads cannot safely use different factories. > It's also not thread-safe, as the variable is not guaranteed to be published safely. > Should either make the variable volatile, or synchronize both getter and setter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira