commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CSV-69) Eliminate CSVPrinterTest.equals(String[][], String[][]) by using Assert.assertArrayEquals
Date Fri, 16 Mar 2012 14:05:39 GMT

     [ https://issues.apache.org/jira/browse/CSV-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Benedikt Ritter updated CSV-69:
-------------------------------

    Attachment: CSV-69.patch

I've created a patch. Note that CSVParserTest uses CSVPrinterTest.assertArrayEquals(). assertArrayEquals
seems to be misplaced in CSVPrinterTest. I guess it would be better create something like
ArrayAsserts and move that method there. Please comment on this.

TIA
Benedikt
                
> Eliminate CSVPrinterTest.equals(String[][], String[][]) by using Assert.assertArrayEquals
> -----------------------------------------------------------------------------------------
>
>                 Key: CSV-69
>                 URL: https://issues.apache.org/jira/browse/CSV-69
>             Project: Commons CSV
>          Issue Type: Test
>            Reporter: Benedikt Ritter
>         Attachments: CSV-69.patch
>
>
> CSVPrinterTest uses an equals method to compare two dimensional String arrays. Since
the project has been updated to JUnit 4, Assert.assertArrayEquals() can be used instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message