commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary D. Gregory (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (VFS-407) reading a RAM FileSystem file fails because it never returns EOF -1.
Date Wed, 21 Mar 2012 15:31:41 GMT

    [ https://issues.apache.org/jira/browse/VFS-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234426#comment-13234426
] 

Gary D. Gregory commented on VFS-407:
-------------------------------------

Can you please provide a patch against trunk and grant the ASF license (a check box when you
upload)? 

A unit test that shows the problem if the suggested fix is not in place would be best.

Thank you,
Gary
                
> reading a RAM FileSystem file fails because it never returns EOF -1.
> --------------------------------------------------------------------
>
>                 Key: VFS-407
>                 URL: https://issues.apache.org/jira/browse/VFS-407
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Miroslav Pokorny
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> RamFileRandomAccessContent
> ORIGINAL
> @Override
>             public int read(byte[] b, int off, int len) throws IOException
>             {
>                 int retLen = Math.min(len, getLeftBytes());
>                 RamFileRandomAccessContent.this.readFully(b, off, retLen);
>                 return retLen;
>             }
> // getLeftBytes() returns 0 when empty. retLen is 0 when empty and never -1.
> FIXED
>             // HACK Patched to return -1 when empty previously it returned 0
>             @Override
>             public int read(final byte[] b, final int off, final int len) throws IOException
{
>                 int retLen = InputStreams.END;
>                 final int left = RamFileRandomAccessContent.this.getLeftBytes();
>                 if (left > 0) {
>                     retLen = Math.min(len, left);
>                     RamFileRandomAccessContent.this.readFully(b, off, retLen);
>                 }
>                 return retLen;
>             }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message