commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (Created) (JIRA)" <>
Subject [jira] [Created] (CSV-81) Token.Type.isReady could perhaps be removed
Date Thu, 22 Mar 2012 18:42:23 GMT
Token.Type.isReady could perhaps be removed

                 Key: CSV-81
             Project: Commons CSV
          Issue Type: Improvement
            Reporter: Sebb

The isReady field is written in lots of places, but only read in 2 places:

1) CSVParser.getRecord() uses it to determine if there was any data found at EOF
2) CSVLexer.nextToken uses it to determine when to exit the loop, but could equally probably
check for type == INVALID

It ought to be possible to simplify this considerably since the only usage external to the
Lexer is to distinguish the EOF case.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message