commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (Commented) (JIRA)" <>
Subject [jira] [Commented] (CSV-75) ExtendedBufferReader does not handle EOL consistently
Date Tue, 27 Mar 2012 00:37:26 GMT


Sebb commented on CSV-75:

Yes, perhaps it should be done by the lexer. But the quickest fix would be to patch the reader.

I wonder whether ExtendedBufferReader is actually necessary; lookAhead() could easily be provided
by the Lexer class.
And I'm not sure that readAgain() is really necessary.
> ExtendedBufferReader does not handle EOL consistently
> -----------------------------------------------------
>                 Key: CSV-75
>                 URL:
>             Project: Commons CSV
>          Issue Type: Bug
>            Reporter: Sebb
>         Attachments: CSV-75.patch
> ExtendedBufferReader checks for '\n' (LF) in the read() methods, incrementing linecount
when found.
> However, the readLine() method calls BufferedReader.readLine() which treats CR, LF and
CRLF equally (and drops them).
> If the code is to be flexible in what it accepts, the class should also allow for CR
alone as a line terminator.
> It should work if the code increments the line counter for CR, and for LF if the previous
character was not CR.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message