commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Claudio Squarcella (Updated) (JIRA)" <>
Subject [jira] [Updated] (SANDBOX-404) Simplify weight model
Date Sun, 04 Mar 2012 00:21:58 GMT


Claudio Squarcella updated SANDBOX-404:

    Attachment: SANDBOX-404_gettingRidOfOrderedMonoid.patch

Hi Simone,

I am attaching a patch that begins with yours and goes one step further, getting rid of {{OrderedMonoid}}
basically everywhere and replacing it with {{Monoid & Comparator}}. That has two reasons:
* separating main operations/properties, so that every algorithm specifies what is needed
in terms of a set of interfaces;
* leading the way to the next refactoring step where {{Monoid}} is converted into {{Addition}},
in order to better represent what it actually does.

So one step is missing, i.e. renaming {{Monoid}} into {{Addition}} (and {{Monoid#append}}
into {{Addition#sum}}, etc) -- but I first wanted to get some feedback on this one.

> Simplify weight model
> ---------------------
>                 Key: SANDBOX-404
>                 URL:
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Simone Tripodi
>         Attachments: SANDBOX-404.patch, SANDBOX-404_gettingRidOfOrderedMonoid.patch
> As discussed on {{dev@}}, {{Zero}}, {{Semigroup}} and {{Monoid}} can be merged directly
in one single interface

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message