commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (Resolved) (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CSV-80) CSVLexer.nextToken does not need wsBuf
Date Thu, 22 Mar 2012 18:26:22 GMT

     [ https://issues.apache.org/jira/browse/CSV-80?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebb resolved CSV-80.
---------------------

    Resolution: Fixed

Removal of the buffer improves performance by about 25%
                
> CSVLexer.nextToken does not need wsBuf
> --------------------------------------
>
>                 Key: CSV-80
>                 URL: https://issues.apache.org/jira/browse/CSV-80
>             Project: Commons CSV
>          Issue Type: Bug
>            Reporter: Sebb
>
> CSVLexer.nextToken carefully saves leading whitespace in wsBuf if leadingSpacesIgnored
is *true*.
> Later on, if leadingSpacesIgnored is *false*, it adds the contents of wsBuf to the token
content field.
> It's not entirely clear what this was intended to do, but at present it achieves nothing;
tests pass without it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message