commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Bourg (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CSV-70) Improve readability of CSVLexer
Date Mon, 26 Mar 2012 13:02:30 GMT

    [ https://issues.apache.org/jira/browse/CSV-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238350#comment-13238350
] 

Emmanuel Bourg commented on CSV-70:
-----------------------------------

Adding a token type for the comments is sensible, but I would keep it internal to the lexer,
the parser would just ignore it.
                
> Improve readability of CSVLexer
> -------------------------------
>
>                 Key: CSV-70
>                 URL: https://issues.apache.org/jira/browse/CSV-70
>             Project: Commons CSV
>          Issue Type: Improvement
>          Components: Parser
>    Affects Versions: 1.0
>            Reporter: Benedikt Ritter
>             Fix For: 1.0
>
>
> There are several things that can be improved in the token lexer (this has also been
discussed on ML, see http://markmail.org/thread/c6x5ji4v44nx5k4h):
> * Remove Token input parameter in nextToken()
> * Add convenience methods isDelimiter(c) and isEncapsulator(c)
> * Remove current caracter input parameter from methods
> * If possible: replace while(true) loops

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message