commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CSV-55) Replace while(true)-loop in CSVParser.getRecord() with do-while-loop
Date Mon, 12 Mar 2012 13:58:40 GMT
Replace while(true)-loop in CSVParser.getRecord() with do-while-loop
--------------------------------------------------------------------

                 Key: CSV-55
                 URL: https://issues.apache.org/jira/browse/CSV-55
             Project: Commons CSV
          Issue Type: Improvement
          Components: Parser
    Affects Versions: 1.0
            Reporter: Benedikt Ritter
            Priority: Trivial


The current implementation of {{getRecords()}} uses a while(true) loop, that gets canceled
by an if statement:

{code:java}
while (true) {
    reusableToken.reset();
    lexer.nextToken(reusableToken);
    // omitted
    if(reusableToken.type != TOKEN) {
        break;
    }
}
{code}

This should be replaced by a do-while-loop:
{code:java}
do {
    reusableToken.reset();
    lexer.nextToken(reusableToken);
    // omitted
} while (reusableToken.type == TOKEN);
{code}


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message