commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simone Tripodi (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SANDBOX-416) Improve DFS/BFS visit detecting multiple states and related actions instead of just stop/continue
Date Tue, 27 Mar 2012 21:42:26 GMT

    [ https://issues.apache.org/jira/browse/SANDBOX-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239975#comment-13239975
] 

Simone Tripodi commented on SANDBOX-416:
----------------------------------------

very well done, I like the actual behavior :)

Issue can be IMHO resolved, the only thing I would suggest you to improve is, when comparing
values, putting expected values first, i.e. inetsad of 

{code}
if ( stateAfterEdgeDiscovery != VisitState.CONTINUE )
{code}

it could be

{code}
if ( VisitState.CONTINUE != stateAfterEdgeDiscovery )
{code}

and constants could be statically imported. Not an issue, just a matter of having clean code.

well done!
-Simo

                
> Improve DFS/BFS visit detecting multiple states and related actions instead of just stop/continue
> -------------------------------------------------------------------------------------------------
>
>                 Key: SANDBOX-416
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-416
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Simone Tripodi
>            Assignee: Claudio Squarcella
>
> As discussed in [ML|http://mail-archives.apache.org/mod_mbox/commons-dev/201203.mbox/%3CCAAqLGLOhZYC8qvT4TLugsnqCgw9BQ-%2BkYoGXVrKASy7PDZdeoQ%40mail.gmail.com%3E],
{{org.apache.commons.graph.visit.GraphVisitHandler}} methods that return {{boolean}} flags
can be sometimes not so intuitive.
> The proposal is replacing {{boolean}} flags return statements with an enumeration values
{{ABORT}}, {{CONTINUE}}, {{SKIP}} to identify
>  * visit has to be immediately terminated
>  * visit can continue;
>  * current node children visit can be skipped.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message