commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luc Maisonobe (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-758) Fields which could be private and/or final
Date Sat, 03 Mar 2012 13:13:56 GMT

    [ https://issues.apache.org/jira/browse/MATH-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221579#comment-13221579
] 

Luc Maisonobe commented on MATH-758:
------------------------------------

I confirm the use of protected variables in ODE is a design choice.
It was driven by performance considerations and the need to change data in place at several
levels and avoid copying as much as possible. This is also the reason why tha API provides
array as placeholders that must be filled in by the equation implementation.

If the API were redesigned now, with modern JVM that handle this far better than a few years
ago, of course the design decisions would not be the same. However, this API is heavily used
and would require changes in all user code, so I would not do it a few days before a release.
                
> Fields which could be private and/or final
> ------------------------------------------
>
>                 Key: MATH-758
>                 URL: https://issues.apache.org/jira/browse/MATH-758
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Sebb
>
> BaseAbstractUnivariateIntegrator has several fields that are not currently changed after
construction and could be final:
> protected double absoluteAccuracy;
> protected double relativeAccuracy;
> protected int minimalIterationCount;
> protected Incrementor iterations;
> protected Incrementor evaluations;
> These all have getters as well, so could also be made private.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message