commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CSV-84) Comment handling
Date Sat, 24 Mar 2012 14:54:25 GMT

    [ https://issues.apache.org/jira/browse/CSV-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237549#comment-13237549
] 

Sebb commented on CSV-84:
-------------------------

At present (r1304503), the comment introducer is not recognised whilst processing a value.
It is only recognised at the start of a value.

This seems wrong, as it makes it impossible to add a trailing comment to the end of a record
without adding a preceeding delimiter. This is not consistent, see below:

{code}
# No comment following, 4 values found
a,b,c,d<EOL>
d,e,f,g# comment treated as part of 4th value<EOL>
h,i,j,k,# this will be recognised as a comment following 4 fields<EOL>
l,m,n,o,<EOL>
# previous line should have 5 fields but actually gets merged to previous line.
{code}

Comments currently only work correctly at the start of a record.
                
> Comment handling
> ----------------
>
>                 Key: CSV-84
>                 URL: https://issues.apache.org/jira/browse/CSV-84
>             Project: Commons CSV
>          Issue Type: New Feature
>            Reporter: Sebb
>
> Comment handling is not currently fully documented / tested.
> There are several possible situations:
> 1) trailing comment following one or more values
> 2) comment marker starts in the first column
> 3) comment marker starts in the first non-whitespace column
> How should these be handled?
> 1) The trailing comment should be ignored
> 2) Entire line should be ignored, i.e. don't treat it as a blank line
> 3) This is trickier: if whitespace is being trimmed, treat as 2, else treat as 1, i.e.
there is a single value containing whitespace
> It might also be useful to consider returning comments to the application program as
part of CSVRecord.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message