commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simone Tripodi (Commented) (JIRA)" <>
Subject [jira] [Commented] (SANDBOX-416) Improve DFS/BFS visit states
Date Mon, 26 Mar 2012 07:14:29 GMT


Simone Tripodi commented on SANDBOX-416:

Good morning!

It looks very good, before resolving the issue I suggest to handle the {{ABORT}} state in
every method - maybe the user had enough of visiting the graph and evaluated the visit is

When {{ABORT}} is detected, it just stop visiting (different from {{SKIP}} that should skip
only the subtree) and invokes the {{onCompleted()}}.

TIA and well done,
> Improve DFS/BFS visit states
> ----------------------------
>                 Key: SANDBOX-416
>                 URL:
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Graph
>            Reporter: Simone Tripodi
>            Assignee: Claudio Squarcella
> As discussed in [ML|],
{{org.apache.commons.graph.visit.GraphVisitHandler}} methods that return {{boolean}} flags
can be sometimes not so intuitive.
> The proposal is replacing {{boolean}} flags return statements with an enumeration values
{{ABORT}}, {{CONTINUE}}, {{SKIP}} to identify
>  * visit has to be immediately terminated
>  * visit can continue;
>  * current node children visit can be skipped.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message