commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IO-305) New copy() method in IOUtils that takes additional offset, length and buffersize arguments
Date Sat, 17 Mar 2012 11:59:38 GMT

    [ https://issues.apache.org/jira/browse/IO-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231927#comment-13231927
] 

Sebb commented on IO-305:
-------------------------

The default buffer size of 4096 was chosen because it gives good performance.

Have you any performance tests that show otherwise?

If so, we can consider implementing this for all the copyLarge methods, see: IO-308

bq. Is the check for len == -1 really a performance issue

Code no longer checks the length twice; I reimplemented the loop in order to support returning
the copied length.


                
> New copy() method in IOUtils that takes additional offset, length and buffersize arguments
> ------------------------------------------------------------------------------------------
>
>                 Key: IO-305
>                 URL: https://issues.apache.org/jira/browse/IO-305
>             Project: Commons IO
>          Issue Type: New Feature
>          Components: Utilities
>            Reporter: Manoj Mokashi
>            Priority: Minor
>             Fix For: 2.2
>
>         Attachments: IOUtils.java, IOUtilsTest.java
>
>
>     /**
>      * Copy from input to output stream
>      * @param is : input stream
>      * @param os : output stream
>      * @param offset : number of bytes to skip from input before copying
>      *         -ve values are ignored
>      * @param len : number of bytes to copy. -1 means all
>      * @param bufferSize : buffer size to use for copying
>      * @throws IOException
>      */
>     public static void copy( InputStream is, OutputStream os, int offset, int len, int
bufferSize) throws IOException
>        

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message