Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Tue, 7 Feb 2012 21:20:59 +0000 (UTC)
From: "Moandji Ezana (Commented) (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <1970456522.10472.1328649659739.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: <790082.1758.1328079298665.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (DBUTILS-87) Return generated key on insert
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DBUTILS-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202804#comment-13202804 ] 

Moandji Ezana commented on DBUTILS-87:
--------------------------------------

"Looking at this patch I noticed that there are two other possible calls which users might want to create the prepared statement:

prepareStatement(String sql, int[] columnIndexes)
prepareStatement(String sql, String[] columnNames)"

What would you see as the API for this? While I agree that those could be useful, I'm not sure it's really necessary:

1. Multi-column primary keys might be handled by the JDBC driver, if all columns are defined as being part of the primary key. This is pure speculation on my part.

2. Multi-column primary keys are fairly rare.

3. Whatever the API we come up with has to be replicated in the AsyncQueryRunner, so it's a lot of extra methods.

"Otherwise, the patch is missing (as noted above) JavaDocs and the async implementation, but looks sound. If you can update your patch with these additional things, I'll look to commit it. Thanks!"

Cool. I'll try to make time for it this week.
                
> Return generated key on insert
> ------------------------------
>
>                 Key: DBUTILS-87
>                 URL: https://issues.apache.org/jira/browse/DBUTILS-87
>             Project: Commons DbUtils
>          Issue Type: New Feature
>            Reporter: Moandji Ezana
>            Assignee: William R. Speirs
>         Attachments: QueryRunner_insert.txt
>
>
> It would be useful to have an insert method on QueryRunner that returns the id of the new record.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira