Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6680195A7 for ; Sun, 19 Feb 2012 16:25:02 +0000 (UTC) Received: (qmail 14683 invoked by uid 500); 19 Feb 2012 16:25:02 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 14602 invoked by uid 500); 19 Feb 2012 16:25:02 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 14594 invoked by uid 99); 19 Feb 2012 16:25:01 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 19 Feb 2012 16:25:01 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 19 Feb 2012 16:25:01 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id D5CF51C0D5E for ; Sun, 19 Feb 2012 16:24:40 +0000 (UTC) Date: Sun, 19 Feb 2012 16:24:40 +0000 (UTC) From: =?utf-8?Q?Felix_M=C3=BCller_=28Commented=29_=28JIRA=29?= To: issues@commons.apache.org Message-ID: <1637672242.472.1329668680877.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (LANG-462) FastDateFormat supports parse MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LANG-462?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D132113= 96#comment-13211396 ]=20 Felix M=C3=BCller commented on LANG-462: ----------------------------------- Seems that I should have installed a pure JDK 5 on my machine and run the m= aven build with java-1.5 profile first: As you can see on the CI server, I = forgot one java 6 dependency. I also fixed this with the next attached patc= h. With the use of JDK 5 the FastDateParser has a really curious problem. One = of the test patterns causes the parser to end up in an infinite loop. I deb= ugged through the code: In JDK 5 the Pattern.compile method seems to be bug= gy. You can reproduce the problem when you look into FastDatePrinterTest li= ne 115/116 (with the merged patch) and run the test class FastDateFormat_Pr= interTest. To secure the test I added a timeout of 20 seconds. The attached patch consists of the fully Java 5 compatible classes (I succe= ssfully run "mvn clean package -Pjava-1.5"), some minor clean up and the se= mi-fixed test. I don't know if it would be good to release a class where we cannot say und= er what circumstances it will crash or end up in an infinite loop. =20 > FastDateFormat supports parse > ----------------------------- > > Key: LANG-462 > URL: https://issues.apache.org/jira/browse/LANG-462 > Project: Commons Lang > Issue Type: New Feature > Components: lang.time.* > Reporter: Franz Wong > Fix For: 3.2 > > Attachments: DateParser.patch, LANG-462-FormatCache.patch, LANG-4= 62-Hen.patch, LANG-462_buildfix.patch, LANG-462_buildfix_pending_java6_issu= es.patch, UseFormatCache.patch, lang462.patch, with_interfaces.patch, with_= interfaces2.patch, with_updated_tests.patch > > > Currently FastDateFormat only supports formatting the ISO8601 time zone, = however, it doesn't support parsing such string to Date. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp= a For more information on JIRA, see: http://www.atlassian.com/software/jira