Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Fri, 10 Feb 2012 13:00:59 +0000 (UTC)
From: "Luc Maisonobe (Commented) (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <145498667.24062.1328878859672.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <766734969.20720.1328816640283.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MATH-742) Please make PolynomialSplineFunction
 Serializable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MATH-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205424#comment-13205424 ] 

Luc Maisonobe commented on MATH-742:
------------------------------------

Instead of full file, we often prefer to get patches in the form of diff. It simplifies checking the changes and applying them.

The problem with having non-serializable classes is that this completely prevents them from being used as fields in user-defined classes which may need to be serializable. Serialization is useful in many situations which are not related to long-term storage and we should not prevent it. So as long as there is no identified problem to have serializable classes (such as very big data structures or singletons), then serializable could be added liberally.
                
> Please make PolynomialSplineFunction Serializable
> -------------------------------------------------
>
>                 Key: MATH-742
>                 URL: https://issues.apache.org/jira/browse/MATH-742
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 2.2
>            Reporter: Neil Roeth
>            Priority: Minor
>         Attachments: PolynomialSplineFunction.java
>
>
> PolynomialSplineFunction is not Serializable, while the very similar PolynomialFunction class in the same package is. All that needs to be done is to add the import:
> {{import java.io.Serializable;}}
> and change this:
> {{public class PolynomialSplineFunction implements DifferentiableUnivariateRealFunction}}
> to this:
> {{public class PolynomialSplineFunction implements DifferentiableUnivariateRealFunction, Serializable}}
> I made exactly that modification to a local copy and it serialized successfully.  Before the change, I got serialization errors.
> Thanks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira