commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William R. Speirs (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (DBUTILS-88) Make AsyncQueryRunner be a decorator around a QueryRunner
Date Sat, 11 Feb 2012 20:34:59 GMT

     [ https://issues.apache.org/jira/browse/DBUTILS-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

William R. Speirs updated DBUTILS-88:
-------------------------------------

    Attachment: DBUTILS-88v1.patch

I took this patch one step further and removed the private methods in AsyncQueryRunner as
they're not really needed. This also allowed me to remove extending AbstractQueryRunner.

However, this has API issues. Unfortunately, the inner classes in AsyncQueryRunner were marked
as protected not private, so removing them changes the API. The same is true with removing
extending AbstractQueryRunner.

For 1.5 we can always leave these classes and simply mark them as @Deprecated and then finally
remove the extension of AbstractQueryRunner in v2.0.

Thoughts?
                
> Make AsyncQueryRunner be a decorator around a QueryRunner
> ---------------------------------------------------------
>
>                 Key: DBUTILS-88
>                 URL: https://issues.apache.org/jira/browse/DBUTILS-88
>             Project: Commons DbUtils
>          Issue Type: Task
>            Reporter: Moandji Ezana
>            Priority: Minor
>         Attachments: AsyncQueryRunner_wraps_QueryRunner.txt, DBUTILS-88v1.patch
>
>
> AsyncQueryRunner duplicates much of the code in QueryRunner. Would it be possible for
AsyncQueryRunner to simply decorate a QueryRunner with async functionality, in the same way
a BufferedInputStream might decorate an InputStream?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message