commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IO-299) getPrefixLength returns null if filename has leading slashes
Date Mon, 13 Feb 2012 11:06:59 GMT

    [ https://issues.apache.org/jira/browse/IO-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206805#comment-13206805
] 

Sebb commented on IO-299:
-------------------------

The Javadoc says clearly that Unix and Windows are treated the same, also that invalid names
return null.

Although double-slashes are collapsed to a single slash, this does not apply at the start
of a path, because there they are used for UNC names in Windows.

As far as I can tell, the current behaviour is correct, because UNC paths must have a valid
server name.

The Javadoc should probably be updated to clarify this; it would help to add some examples
(and test cases if necessary).
                
> getPrefixLength returns null if filename has leading slashes
> ------------------------------------------------------------
>
>                 Key: IO-299
>                 URL: https://issues.apache.org/jira/browse/IO-299
>             Project: Commons IO
>          Issue Type: Bug
>          Components: Utilities
>    Affects Versions: 2.0.1, 2.1
>            Reporter: Rick Latrine
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Situation:
> FilenameUtils.getPrefixLength is used in FilenameUtils.doNormalize.
> FilenameUtils.normalize("////I don't want to become null!") returns null.
> Problem:
> Expected was: "I don't want to become null!"
> The method FilenameUtils.getPrefixLength returns -1 for the mentioned string.
> The root problem is found in following lines of code:
> {code:title=FilenameUtils.getPrefixLength}
> ...
>                 int posUnix = filename.indexOf(UNIX_SEPARATOR, 2);
>                 int posWin = filename.indexOf(WINDOWS_SEPARATOR, 2);
>                 if ((posUnix == -1 && posWin == -1) || posUnix == 2 || posWin
== 2) {
>                     return -1;
>                 }
> ...
> {code}
> Solution:
> All leading slashes should be ignored at all, but considering the rest of the string.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message