commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thilina Dampahala (Issue Comment Edited) (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (IO-299) getPrefixLength returns null if filename has leading slashes
Date Sun, 12 Feb 2012 16:10:59 GMT

    [ https://issues.apache.org/jira/browse/IO-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206439#comment-13206439
] 

Thilina Dampahala edited comment on IO-299 at 2/12/12 4:09 PM:
---------------------------------------------------------------

In this case for your input "////I don't want to become null!", I think the expected output
should be
In Unix: 
"//I don't want to become null!"

In Windows: 
\\I don't want to become null!

Any ideas on this?
                
      was (Author: thdamp):
    In this case for your input "////I don't want to become null!", I think the expected output
should be
In Unix: 
"//I don't want to become null!"

In Windows: 
"\\I don't want to become null!"

Any ideas on this?
                  
> getPrefixLength returns null if filename has leading slashes
> ------------------------------------------------------------
>
>                 Key: IO-299
>                 URL: https://issues.apache.org/jira/browse/IO-299
>             Project: Commons IO
>          Issue Type: Bug
>          Components: Utilities
>    Affects Versions: 2.0.1, 2.1
>            Reporter: Rick Latrine
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Situation:
> FilenameUtils.getPrefixLength is used in FilenameUtils.doNormalize.
> FilenameUtils.normalize("////I don't want to become null!") returns null.
> Problem:
> Expected was: "I don't want to become null!"
> The method FilenameUtils.getPrefixLength returns -1 for the mentioned string.
> The root problem is found in following lines of code:
> {code:title=FilenameUtils.getPrefixLength}
> ...
>                 int posUnix = filename.indexOf(UNIX_SEPARATOR, 2);
>                 int posWin = filename.indexOf(WINDOWS_SEPARATOR, 2);
>                 if ((posUnix == -1 && posWin == -1) || posUnix == 2 || posWin
== 2) {
>                     return -1;
>                 }
> ...
> {code}
> Solution:
> All leading slashes should be ignored at all, but considering the rest of the string.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message