commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Moandji Ezana (Commented) (JIRA)" <>
Subject [jira] [Commented] (DBUTILS-88) Make AsyncQueryRunner be a decorator around a QueryRunner
Date Fri, 17 Feb 2012 07:27:59 GMT


Moandji Ezana commented on DBUTILS-88:

Looks good to me. It might be worth marking the other constructors as @Deprecated, too. If
AsyncQueryRunner is about wrapping a QueryRunner, AsyncQueryRunner(ExecutorService executorService,
QueryRunner queryRunner) best expresses that.

Ultimately, it might be worth making QueryRunner an interface that is implemented by both
AsyncQueryRunner and the current QueryRunner (renamed to BasicQueryRunner?).
> Make AsyncQueryRunner be a decorator around a QueryRunner
> ---------------------------------------------------------
>                 Key: DBUTILS-88
>                 URL:
>             Project: Commons DbUtils
>          Issue Type: Task
>            Reporter: Moandji Ezana
>            Priority: Minor
>         Attachments: AsyncQueryRunner_wraps_QueryRunner.txt, DBUTILS-88v1.patch
> AsyncQueryRunner duplicates much of the code in QueryRunner. Would it be possible for
AsyncQueryRunner to simply decorate a QueryRunner with async functionality, in the same way
a BufferedInputStream might decorate an InputStream?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message