commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Damjan Jovanovic (Commented) (JIRA)" <>
Subject [jira] [Commented] (SANSELAN-42) IPTCConstants: final arrays are not immutable
Date Sat, 04 Feb 2012 07:11:57 GMT


Damjan Jovanovic commented on SANSELAN-42:

Most of these ALL_* and *_TYPES arrays are pre-Java-1.5 ways of doing Enums and their values()

It seems like a good idea to do both together: convert to use of Enums, and make arrays immutable
in the process. It's an API breaking change, but the API for the 1.0 release has been broken

> IPTCConstants: final arrays are not immutable
> ---------------------------------------------
>                 Key: SANSELAN-42
>                 URL:
>             Project: Commons Sanselan
>          Issue Type: Bug
>            Reporter: Sebb
> formats.jpeg.iptc.IPTCConstants contains the following public static final arrays:
> Array element are not immutable, even if the array itself is, so the entries could potentially
be corrupted accidentally or deliberately.
> IPTC_PREFIX does not appear to be used, so could perhaps be deleted. If not, it could
be made private and a getter added.
> IPTC_TYPES only appears to be used in IPTCTypeLookup, so could potentially be moved there
and made private.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message