commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Damjan Jovanovic (Commented) (JIRA)" <>
Subject [jira] [Commented] (SANSELAN-63) Audit and fix resource leaks
Date Tue, 21 Feb 2012 15:26:39 GMT


Damjan Jovanovic commented on SANSELAN-63:

Ok I've hacked MCLIRR to work, and committed your patch. Thank you for your contribution.

It finds all kinds of problems, but doesn't find the resource leak in BmpImageParser :-(.
Maybe because ByteSource.getInputStream() returns the stream, and FindBugs can only find streams
that leak within a method? Either way, I'll audit all the calls to ByteSource.getInputStream().

> Audit and fix resource leaks
> ----------------------------
>                 Key: SANSELAN-63
>                 URL:
>             Project: Commons Sanselan
>          Issue Type: Bug
>    Affects Versions: 0.97
>         Environment: Windows 7, Java, 0.97-Incubator
>            Reporter: Adrian Moerchen
>         Attachments: 380440_295155317172029_185275861493309_985773_37867068_n.bmp, finbugs.patch
> The attached image is somehow corrupt (it still can be opened with IrfanView).
> Trying to read the image information with {{Sanselan.getImageInfo(file)}} results in
an IOException.
> After this the image is still locked on the file system, and can't be deleted for example.
I expected it to be immediately get unlocked on the file system, after the error occured.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message