commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Roeth (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-742) Please make PolynomialSplineFunction Serializable
Date Thu, 16 Feb 2012 18:48:59 GMT

    [ https://issues.apache.org/jira/browse/MATH-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209596#comment-13209596
] 

Neil Roeth commented on MATH-742:
---------------------------------

I'm kind of surprised at this result.  One developer out of three objected, and that's a "consensus"?
 That developer basically said this class should only be Serialized if X, Y and Z were true.
 I responded that yes, indeed, it was precisely X,Y and Z that were true and in fact were
what led to my request.  I'd have thought that, all objections having been answered, it would
have been a done deal then.  Particularly since PolynomialFunction, a class in the same package,
is already Serializable. Instead, "Won't Fix"?  What objections were raised that were not
answered?

Luc, the work arounds you propose are poorer practice than using Serializable exactly as it
was intended.  The work arounds both boil down to "implement serialization of PolynomialSplineFunction
through home grown custom code instead of simply adding the Java standard 'implements Serializable'".
That is not a better solution, so I am going to keep my locally customized version of the
class and hope you someday change your mind.
                
> Please make PolynomialSplineFunction Serializable
> -------------------------------------------------
>
>                 Key: MATH-742
>                 URL: https://issues.apache.org/jira/browse/MATH-742
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 2.2
>            Reporter: Neil Roeth
>            Priority: Minor
>         Attachments: PolynomialSplineFunction.java
>
>
> PolynomialSplineFunction is not Serializable, while the very similar PolynomialFunction
class in the same package is. All that needs to be done is to add the import:
> {{import java.io.Serializable;}}
> and change this:
> {{public class PolynomialSplineFunction implements DifferentiableUnivariateRealFunction}}
> to this:
> {{public class PolynomialSplineFunction implements DifferentiableUnivariateRealFunction,
Serializable}}
> I made exactly that modification to a local copy and it serialized successfully.  Before
the change, I got serialization errors.
> Thanks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message