commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-744) BigFraction.doubleValue() returns Double.NaN for large numerators or denominators
Date Sun, 12 Feb 2012 22:12:59 GMT

    [ https://issues.apache.org/jira/browse/MATH-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206532#comment-13206532
] 

Gilles commented on MATH-744:
-----------------------------

Sorry to be picky, but it is better to avoid clumping many tests in the same test function,
especially if they check different things.
In this case, you could create a new test method, e.g. "testDoubleValueForLargeNumeratorAndDenominator".
Also, in addition to checking that the result is not NaN, you should check that the result
is the expected value.
Thanks for your contribution.

                
> BigFraction.doubleValue() returns Double.NaN for large numerators or denominators
> ---------------------------------------------------------------------------------
>
>                 Key: MATH-744
>                 URL: https://issues.apache.org/jira/browse/MATH-744
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Thundre
>         Attachments: src.patch
>
>
> The current implementation of doubleValue() divides numerator.doubleValue() / denominator.doubleValue().
 BigInteger.doubleValue() fails for any number greater than Double.MAX_VALUE.  So if the user
has 308-digit numerator or denominator, the resulting quotient fails, even in cases where
the result would be well inside Double's range.
> I have a patch to fix it, if I can figure out how to attach it here I will.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message