commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thilina Dampahala (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (IO-300) FileUtils.moveDirectoryToDirectory removing source directory
Date Tue, 14 Feb 2012 02:04:59 GMT

     [ https://issues.apache.org/jira/browse/IO-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Thilina Dampahala updated IO-300:
---------------------------------

    Attachment:     (was: IO-300.patch)
    
> FileUtils.moveDirectoryToDirectory removing source directory
> ------------------------------------------------------------
>
>                 Key: IO-300
>                 URL: https://issues.apache.org/jira/browse/IO-300
>             Project: Commons IO
>          Issue Type: Bug
>            Reporter: dennis lucero
>
> Since moveDirectoryToDirectory performs a copy then delete, if you specify a target directory
that is a subdirectory of the source, everything under the source directory is deleted.
> Steps to recreate:
>         File dest = new File("/tmp/dir1/dir2");
>         File src  = new File("/tmp/dir1/");
>         dest.mkdirs();
>         System.out.println(src.exists());
>         FileUtils.moveDirectoryToDirectory(src, dest, false);
>         System.out.println(src.exists());
> Output:
>  true
>  false
> If you try the same thing with a move command on Linux, you receive: "mv: cannot move
`dir1/' to a subdirectory of itself, `dir1/dir2/dir1'"
> Maybe throw an exception if dest.getCanonicalPath().startsWith(src.getCanonicalPath())

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message