Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 5 Jan 2012 22:20:40 +0000 (UTC)
From: "Sebb (Updated) (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <707031370.11923.1325802040040.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <80691529.13696.1300549109558.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (NET-382) Subclasses of SocketClient should use
 _input_ and _output_ rather than calling _socket_.getInputStream() etc
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/NET-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb updated NET-382:
---------------------

    Issue Type: Improvement  (was: Bug)
    
> Subclasses of SocketClient should use _input_ and _output_ rather than calling _socket_.getInputStream() etc
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: NET-382
>                 URL: https://issues.apache.org/jira/browse/NET-382
>             Project: Commons Net
>          Issue Type: Improvement
>            Reporter: Sebb
>         Attachments: sockclient-socket-private.diff
>
>
> SocketClient._connectAction() sets up \_input\_ and \_output\_ from \_socket\_ so it is wasteful to do this again in subclasses.
> Potentially consider making \_socket\_ private?
> However, this would currently break most of the "S" versions of the protocols, unless SocketClient is extended to handle their needs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira