Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Mon, 2 Jan 2012 07:21:31 +0000 (UTC)
From: =?utf-8?Q?S=C3=A9bastien_Brisard_=28Issue_Comment_Edited=29_=28JIRA=29?=
 <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <2056807161.57446.1325488891272.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <151010639.7269.1317297525712.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Issue Comment Edited] (MATH-677) About package "transform"
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/MATH-677?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D131779=
66#comment-13177966 ]=20

S=C3=A9bastien Brisard edited comment on MATH-677 at 1/2/12 7:20 AM:
----------------------------------------------------------------

h4. Exceptions
* remove references to {{MathRuntimeException}},
* throw more specific {{Math...Exception}} instances instead of standard {{=
IAE}}.

As discussed on the [mailing-list|http://mail-archives.apache.org/mod_mbox/=
commons-dev/201112.mbox/%3CCAGRH7Hq24t8O5hCPawVWFU1tOLAhcBrBjF%2BYh69zZivTn=
ZRKFQ%40mail.gmail.com%3E], {{MathIllegalArgumentException}} (as opposed to=
 more specific subclasses) are returned for non-power-of-two datasets.

(/) {{FastCosineTransformer}}: done in {{r1226359}}
(/) {{FastFourierTransformer}}: done in {{r1226053}}
(x) {{FastHadamardTransformer}}
(x) {{FastSineTransformer}}
               =20
      was (Author: celestin):
    h4. Exceptions
* remove references to {{MathRuntimeException}},
* throw more specific {{Math...Exception}} instances instead of standard {{=
IAE}}.

As discussed on the [mailing-list|http://mail-archives.apache.org/mod_mbox/=
commons-dev/201112.mbox/%3CCAGRH7Hq24t8O5hCPawVWFU1tOLAhcBrBjF%2BYh69zZivTn=
ZRKFQ%40mail.gmail.com%3E], {{MathIllegalArgumentException}} (as opposed to=
 more specific subclasses) are returned for non-power-of-two datasets.

(x) {{FastCosineTransformer}}: done in {{r1226359}}
(/) {{FastFourierTransformer}}: done in {{r1226053}}
(x) {{FastHadamardTransformer}}
(x) {{FastSineTransformer}}
                 =20
> About package "transform"
> -------------------------
>
>                 Key: MATH-677
>                 URL: https://issues.apache.org/jira/browse/MATH-677
>             Project: Commons Math
>          Issue Type: Improvement
>            Reporter: Gilles
>            Assignee: S=C3=A9bastien Brisard
>            Priority: Minor
>              Labels: api-change
>             Fix For: 3.0
>
>
> Classes in package "o.a.c.m.transform" might require some changes in orde=
r to conform to goals set for the next major release.
> Some observations:
> # Exceptions
> ## Should remove use of deprecated "MathRuntimeException"
> ## Should throw more specific "Math...Exception" instances instead of sta=
ndard IAE
> # Interface "RealTransformer" (and implementations) contain non-conforman=
t method names (e.g. "inversetransform" instead of "inverseTransform"). {co=
lor:red}Fixed in {{r1208293}}.{color}
> # "FastFourierTransformer":
> ## Methods "mdfft" and "verifyDataSet" take an argument of type "Object" =
(to allow an argument with an unspecified number of dimensions)
> ## The "RootsOfUnity" helper class could be moved to the "complex" packag=
e
> ## For clarity, multidimensional transform should be moved to a class of =
its own (and I also wonder whether the "MultiDimensionalComplexMatrix" name=
 is not misleading)
> # "FastFourierTransformer", "FastSineTranformer" and "FastCosineTranforme=
r" define public methods "tranform2" and "inversetransform2" but they are n=
ot part of an interface. {color:red}As of {{r1213157}}, these methods have =
been removed, and replaced by factory methods {{create()}} and {{createUnit=
ary()}} (FFT) or {{createOrthogonal()}} (FCT, FST).{color}
> # Code uses variables that start with an uppercase. {color:red}Fixed, tog=
ether with various formatting issues.{color}
> # "FastHadamardTransformer" contains illegible developer documentation (s=
ee Javadoc for protected method "fht"). {color:red}Tried to improve things =
in {{r1208986}}, but things are still a bit obscure. Besides, the link prov=
ided is broken. Will look into that.{color}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira