Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Mon, 16 Jan 2012 06:49:40 +0000 (UTC)
From: =?utf-8?Q?S=C3=A9bastien_Brisard_=28Commented=29_=28JIRA=29?=
 <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <1972948614.43771.1326696580905.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <936624307.37430.1326445659716.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MATH-733) Add LogNormal distribution
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/MATH-733?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D131867=
32#comment-13186732 ]=20

S=C3=A9bastien Brisard commented on MATH-733:
----------------------------------------

Hi Dennis,
thanks for this contribution. I've looked into it, and am uncomfortable wit=
h the naming conventions {{mean}} and {{standardDeviation}} which are *not*=
 the mean and sd of the log-normal distribution, but rather the underlying =
normal distribution.
Would you object to my renaming all these parameters and class variables to=
 {{scale}} and {{shape}}, as you yourself mention these naming conventions =
in the javadoc? I would then move your explanation of the definition of the=
se parameters to the class's documentation comment.
>From the user's perspective (heavily relying on automatic completion) I thi=
nk it is dangerous that {{getMean()}} should *not* return the mean value of=
 the current distribution. Of course, your javadoc comments are very clear,=
 but... Also, my experience in materials science is that people are always =
a bit "fuzzy" about log-normal distributions. What they call "sigma" is nev=
er very clear...
Please let me know what you think.
               =20
> Add LogNormal distribution
> --------------------------
>
>                 Key: MATH-733
>                 URL: https://issues.apache.org/jira/browse/MATH-733
>             Project: Commons Math
>          Issue Type: New Feature
>            Reporter: Dennis Hendriks
>              Labels: distribution
>             Fix For: 3.0
>
>         Attachments: lognormal_distribution.patch
>
>
> It would be nice to have a log-normal distribution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira