commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedikt Ritter (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SANDBOX-376) [BeanUtils2] Extract magic numbers in AccessibleObjectsRegistry.getObjectTransformationCosts(...) to constants
Date Tue, 31 Jan 2012 19:32:11 GMT

     [ https://issues.apache.org/jira/browse/SANDBOX-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Benedikt Ritter updated SANDBOX-376:
------------------------------------

    Attachment: SANDBOX-376.txt

I've created a patch for that issue. I prefixed the constants with TRANSFORMATION_COSTS. Please
let me know, what you think about that, because the constant names are very long now. Beside
that, I have added some commentary.
                
> [BeanUtils2] Extract magic numbers in AccessibleObjectsRegistry.getObjectTransformationCosts(...)
to constants
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: SANDBOX-376
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-376
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: BeanUtils2
>            Reporter: Benedikt Ritter
>         Attachments: SANDBOX-376.txt
>
>
> As discussed on the ML, the magic numbers in the above mentioned method should be extracted
to local constants.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message