commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-733) Add LogNormal distribution
Date Tue, 17 Jan 2012 13:10:41 GMT

    [ https://issues.apache.org/jira/browse/MATH-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187642#comment-13187642
] 

Gilles commented on MATH-733:
-----------------------------

bq. LogNormalDistribution constructor: LocalizedFormats.STANDARD_DEVIATION -> change to
LocalizedFormats.NOT_POSITIVE_SHAPE

The change should be to "LocalizedFormats.SHAPE".

bq. I would prefer to stick with {@link ...}, [...]

+1
Also, we should be careful not to refer to the "private" API from the doc of the "public"
one. I mean that you cannot just replace everywhere
{noformat}
<a href="#parameters">scale</a>
{noformat}
with
{noformat}
{@link #scale}
{noformat}

I think that we can safely assume that the users will read _all_ the class documentation;
it is not necessary to have those many pointers "back to the top" (i.e. the {{<a href="#parameters">}}
links).

                
> Add LogNormal distribution
> --------------------------
>
>                 Key: MATH-733
>                 URL: https://issues.apache.org/jira/browse/MATH-733
>             Project: Commons Math
>          Issue Type: New Feature
>            Reporter: Dennis Hendriks
>            Assignee: S├ębastien Brisard
>              Labels: distribution
>             Fix For: 3.0
>
>         Attachments: lognormal_distribution.patch
>
>
> It would be nice to have a log-normal distribution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message