Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 1 Dec 2011 06:39:44 +0000 (UTC)
From: "Elijah Zupancic (Commented) (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <1334598420.29862.1322721584394.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1163414616.40872.1316396888851.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (CHAIN-58) Update Chain Context interface to use
 K,V generics
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CHAIN-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160684#comment-13160684 ] 

Elijah Zupancic commented on CHAIN-58:
--------------------------------------

Hi Simo,
I just tried to apply the patch to a clean check out and it completed with no problems. Here is the output of how I applied the patch.

{noformat}
elijah@kirin:~/dev$ svn co "http://svn.apache.org/repos/asf/commons/proper/chain/trunk" chain-clean
... Lots of output
elijah@kirin:~/dev$ cd chain-clean
elijah@kirin:~/dev/chain-clean$ patch -p0 < ../chain-trunk/chain-58.diff 
patching file src/test/java/org/apache/commons/chain/impl/NonDelegatingFilter.java
Hunk #1 succeeded at 29 with fuzz 1.
patching file src/test/java/org/apache/commons/chain/impl/DelegatingFilter.java
Hunk #1 succeeded at 29 with fuzz 1.
patching file src/test/java/org/apache/commons/chain/impl/NonDelegatingCommand.java
Hunk #1 succeeded at 29 with fuzz 1.
patching file src/test/java/org/apache/commons/chain/generic/DispatchLookupCommandTestCase.java
patching file src/test/java/org/apache/commons/chain/generic/LookupCommandTestCase.java
patching file src/test/java/org/apache/commons/chain/generic/DispatchCommandTestCase.java
patching file src/main/java/org/apache/commons/chain/impl/ContextBase.java
patching file src/main/java/org/apache/commons/chain/impl/CatalogBase.java
Hunk #1 succeeded at 37 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/impl/CatalogFactoryBase.java
Hunk #2 succeeded at 31 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/impl/ChainBase.java
Hunk #1 succeeded at 36 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/CatalogFactory.java
Hunk #1 succeeded at 38 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/Chain.java
Hunk #1 succeeded at 53 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/Context.java
Hunk #1 succeeded at 60 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/Filter.java
Hunk #1 succeeded at 43 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/config/ConfigRegisterRule.java
patching file src/main/java/org/apache/commons/chain/config/ConfigCatalogRule.java
patching file src/main/java/org/apache/commons/chain/Catalog.java
Hunk #1 succeeded at 31 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/generic/DispatchLookupCommand.java
patching file src/main/java/org/apache/commons/chain/generic/LookupCommand.java
Hunk #1 succeeded at 46 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/generic/CopyCommand.java
Hunk #1 succeeded at 31 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/generic/RemoveCommand.java
Hunk #1 succeeded at 30 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/generic/DispatchCommand.java
patching file src/main/java/org/apache/commons/chain/web/faces/FacesGetLocaleCommand.java
patching file src/main/java/org/apache/commons/chain/web/faces/FacesSetLocaleCommand.java
patching file src/main/java/org/apache/commons/chain/web/AbstractGetLocaleCommand.java
Hunk #1 succeeded at 33 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletGetLocaleCommand.java
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletPathMapper.java
patching file src/main/java/org/apache/commons/chain/web/servlet/PathInfoMapper.java
patching file src/main/java/org/apache/commons/chain/web/servlet/ServletSetLocaleCommand.java
patching file src/main/java/org/apache/commons/chain/web/servlet/ChainProcessor.java
patching file src/main/java/org/apache/commons/chain/web/servlet/RequestParameterMapper.java
patching file src/main/java/org/apache/commons/chain/web/portlet/PortletSetLocaleCommand.java
patching file src/main/java/org/apache/commons/chain/web/portlet/PortletGetLocaleCommand.java
patching file src/main/java/org/apache/commons/chain/web/AbstractSetLocaleCommand.java
Hunk #1 succeeded at 34 with fuzz 1.
patching file src/main/java/org/apache/commons/chain/Command.java
Hunk #1 succeeded at 79 with fuzz 1.
patching file pom.xml
{noformat}
                
> Update Chain Context interface to use K,V generics
> --------------------------------------------------
>
>                 Key: CHAIN-58
>                 URL: https://issues.apache.org/jira/browse/CHAIN-58
>             Project: Commons Chain
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Elijah Zupancic
>             Fix For: 2.0
>
>         Attachments: chain-58.diff
>
>
> As discussed in the mailing list, I am suggesting that we change the definition of Context from:
> {noformat}
> public interface Context extends Map<String, Object> {
> {noformat}
> to:
> {noformat}
> public interface Context<K, V> extends Map<K, V> {
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira