commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Thomas (Commented) (JIRA)" <>
Subject [jira] [Commented] (POOL-203) GenericKeyedObjectPool.ObjectDeque could be better encapsulated
Date Sat, 17 Dec 2011 20:17:31 GMT


Mark Thomas commented on POOL-203:

This is an awful lot of work that adds quite a lot of code for what appears to be relatively
little benefit. I'd rather keep the code clean.
> GenericKeyedObjectPool.ObjectDeque could be better encapsulated
> ---------------------------------------------------------------
>                 Key: POOL-203
>                 URL:
>             Project: Commons Pool
>          Issue Type: Improvement
>            Reporter: Sebb
>            Priority: Minor
> GenericKeyedObjectPool.ObjectDeque is currently basically just a collection of Objects
with getters.
> This necessarily exposes the implementation, and makes adding invariant checks a lot
harder - e.g. ensuring createCount >=0.
> The suggestion is to replace the getters with functional methods, for example:
> objectDeque.getCreateCount().incrementAndGet() => objectDeque.createdEntry();
> objectDeque.getAllObjects().put(t, p); => objectDeque.addNew(t, p);
> objectDeque.getIdleObjects().addFirst(p)/addLast(p) => objectDeque.idle(p,getLifo())
> The new methods could include assertions for invariants, and adding debug would be a

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message