commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Damjan Jovanovic (Resolved) (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SANSELAN-46) ExifRewriteTest. failing in Gump
Date Fri, 09 Dec 2011 10:46:40 GMT

     [ https://issues.apache.org/jira/browse/SANSELAN-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Damjan Jovanovic resolved SANSELAN-46.
--------------------------------------

    Resolution: Fixed

EXIF strings are supposed to be 7 bit clean. When they're not, Sanselan parses them incorrectly,
then copies the badly parsed string to the new image. This is why ExifRewriteTest was failing
- at least on *nix.

This was fixed in commit 1212076 by ignoring string differences when the 7 bit unclean string
was copied, so resolving fixed.

                
> ExifRewriteTest. failing in Gump
> --------------------------------
>
>                 Key: SANSELAN-46
>                 URL: https://issues.apache.org/jira/browse/SANSELAN-46
>             Project: Commons Sanselan
>          Issue Type: Bug
>            Reporter: Niall Pemberton
>            Priority: Minor
>
> The ExifRewriteTest.is failing in Gump - it works fine for me (Windows 7 / JDK 1.6) -
but for some reason theres a problem with gump.
> I modified the test to output more information about the point at which its failing (file/dir/fieldTag/byte):
>     http://svn.apache.org/viewvc?view=revision&revision=1003442
> The output from gump shows the following:
> {code}
> -------------------------------------------------------------------------------
> Test set: org.apache.sanselan.formats.jpeg.exif.ExifRewriteTest
> -------------------------------------------------------------------------------
> Tests run: 4, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 4.354 sec <<<
FAILURE!
> testInsert(org.apache.sanselan.formats.jpeg.exif.ExifRewriteTest)  Time elapsed: 1.109
sec  <<< FAILURE!
> junit.framework.AssertionFailedError: Oregon Scientific DS6639 - DSC_0307 - small.jpg,
dirType[1]=0, fieldTag[0]=270, byte[0] expected:<-110> but was:<-17>
> 	at junit.framework.Assert.fail(Assert.java:47)
> 	at junit.framework.Assert.failNotEquals(Assert.java:283)
> 	at junit.framework.Assert.assertEquals(Assert.java:64)
> 	at junit.framework.Assert.assertEquals(Assert.java:156)
> 	at org.apache.sanselan.formats.jpeg.exif.ExifRewriteTest.compare(ExifRewriteTest.java:522)
> 	at org.apache.sanselan.formats.jpeg.exif.ExifRewriteTest.compare(ExifRewriteTest.java:469)
> 	at org.apache.sanselan.formats.jpeg.exif.ExifRewriteTest.testInsert(ExifRewriteTest.java:170)
> testRewriteLossy(org.apache.sanselan.formats.jpeg.exif.ExifRewriteTest)  Time elapsed:
1.044 sec  <<< FAILURE!
> junit.framework.AssertionFailedError: Oregon Scientific DS6639 - DSC_0307 - small.jpg,
dirType[1]=0, fieldTag[0]=270, byte[0] expected:<-110> but was:<-17>
> 	at junit.framework.Assert.fail(Assert.java:47)
> 	at junit.framework.Assert.failNotEquals(Assert.java:283)
> 	at junit.framework.Assert.assertEquals(Assert.java:64)
> 	at junit.framework.Assert.assertEquals(Assert.java:156)
> 	at org.apache.sanselan.formats.jpeg.exif.ExifRewriteTest.compare(ExifRewriteTest.java:522)
> 	at org.apache.sanselan.formats.jpeg.exif.ExifRewriteTest.compare(ExifRewriteTest.java:469)
> 	at org.apache.sanselan.formats.jpeg.exif.ExifRewriteTest.rewrite(ExifRewriteTest.java:249)
> 	at org.apache.sanselan.formats.jpeg.exif.ExifRewriteTest.testRewriteLossy(ExifRewriteTest.java:287)
> testRewriteLossless(org.apache.sanselan.formats.jpeg.exif.ExifRewriteTest)  Time elapsed:
1.074 sec  <<< FAILURE!
> junit.framework.AssertionFailedError: Oregon Scientific DS6639 - DSC_0307 - small.jpg,
dirType[1]=0, fieldTag[0]=270, byte[0] expected:<-110> but was:<-17>
> 	at junit.framework.Assert.fail(Assert.java:47)
> 	at junit.framework.Assert.failNotEquals(Assert.java:283)
> 	at junit.framework.Assert.assertEquals(Assert.java:64)
> 	at junit.framework.Assert.assertEquals(Assert.java:156)
> 	at org.apache.sanselan.formats.jpeg.exif.ExifRewriteTest.compare(ExifRewriteTest.java:522)
> 	at org.apache.sanselan.formats.jpeg.exif.ExifRewriteTest.compare(ExifRewriteTest.java:469)
> 	at org.apache.sanselan.formats.jpeg.exif.ExifRewriteTest.rewrite(ExifRewriteTest.java:249)
> 	at org.apache.sanselan.formats.jpeg.exif.ExifRewriteTest.testRewriteLossless(ExifRewriteTest.java:304)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message