commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Thomas (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (POOL-204) GKOP encapsulate poolMap/poolKeyList to ensure invariants?
Date Sat, 17 Dec 2011 19:55:31 GMT

    [ https://issues.apache.org/jira/browse/POOL-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171658#comment-13171658
] 

Mark Thomas commented on POOL-204:
----------------------------------

The data structures are already encapsulated within GKOP. I don't see that adding a further
layer of encapsulation will help. I think some comments in the code would be sufficient.
                
> GKOP encapsulate poolMap/poolKeyList to ensure invariants?
> ----------------------------------------------------------
>
>                 Key: POOL-204
>                 URL: https://issues.apache.org/jira/browse/POOL-204
>             Project: Commons Pool
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Sebb
>            Priority: Minor
>
> In GKOP, poolMap and poolKeyList must be kept in step otherwise "bad things will happen!".
> Might be worth considering encapsulating the data structures in a private class that
ensures this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message