Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Fri, 4 Nov 2011 02:35:33 +0000 (UTC)
From: "Adrian Cumiskey (Commented) (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <1922198095.58183.1320374133408.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1298717541.37266.1319918252278.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (OGNL-35) [PATCH] Improvements to
 {List,Map,Array}PropertyAccessor and ASTProperty
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143700#comment-13143700 ] 

Adrian Cumiskey commented on OGNL-35:
-------------------------------------

patch-OGNL35-v2.txt improves upon and replaces the original one.
                
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
> ------------------------------------------------------------------------
>
>                 Key: OGNL-35
>                 URL: https://issues.apache.org/jira/browse/OGNL-35
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Adrian Cumiskey
>            Priority: Minor
>         Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String constant.
> * ListPropertyAccessor: CPD fix, extracted shared method getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from getSourceAccessor() and getSourceSetter().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira