Return-Path: X-Original-To: apmail-commons-issues-archive@minotaur.apache.org Delivered-To: apmail-commons-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8ACCA7D39 for ; Thu, 3 Nov 2011 06:41:56 +0000 (UTC) Received: (qmail 82931 invoked by uid 500); 3 Nov 2011 06:41:56 -0000 Delivered-To: apmail-commons-issues-archive@commons.apache.org Received: (qmail 82852 invoked by uid 500); 3 Nov 2011 06:41:56 -0000 Mailing-List: contact issues-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: issues@commons.apache.org Delivered-To: mailing list issues@commons.apache.org Received: (qmail 82843 invoked by uid 99); 3 Nov 2011 06:41:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2011 06:41:55 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2011 06:41:53 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 79E5232F667 for ; Thu, 3 Nov 2011 06:41:32 +0000 (UTC) Date: Thu, 3 Nov 2011 06:41:32 +0000 (UTC) From: "Adrian Cumiskey (Created) (JIRA)" To: issues@commons.apache.org Message-ID: <1708740598.54475.1320302492500.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Created] (OGNL-37) [PATCH] Findbugs fixes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [PATCH] Findbugs fixes ---------------------- Key: OGNL-37 URL: https://issues.apache.org/jira/browse/OGNL-37 Project: OGNL Issue Type: Improvement Reporter: Adrian Cumiskey Priority: Minor ExpressionNode: Use StringBuilder instead of String concatenation with '+'. ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() implementation to override PropertyDescriptor. ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always of type String). ASTMethod: Use StringBuilder instead of String concatenation with '+'. DeclaredMethodCacheEntry: Modified equals() implementation to take account of super class fields. OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet for better performance. Javadoc improvements. ASTChain: Remove int boxing, lets rely on autoboxing. ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code. OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary conditional checking. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira