Mailing-List: contact issues-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: issues@commons.apache.org
Date: Thu, 3 Nov 2011 10:09:32 +0000 (UTC)
From: "Maurizio Cucchiara (Commented) (JIRA)" <jira@apache.org>
To: issues@commons.apache.org
Message-ID: 
 <1009621748.55086.1320314972610.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1708740598.54475.1320302492500.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143023#comment-13143023 ] 

Maurizio Cucchiara commented on OGNL-37:
----------------------------------------

Ignore my last message, I have almost forgotten about {{ConcurrentModificationException}}
                
> [PATCH] Findbugs fixes
> ----------------------
>
>                 Key: OGNL-37
>                 URL: https://issues.apache.org/jira/browse/OGNL-37
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Adrian Cumiskey
>            Assignee: Maurizio Cucchiara
>            Priority: Minor
>         Attachments: patch-OGNL37.txt
>
>
> ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
> ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() implementation to override PropertyDescriptor.
> ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always of type String).
> ASTMethod: Use StringBuilder instead of String concatenation with '+'.
> DeclaredMethodCacheEntry: Modified equals() implementation to take account of super class fields.
> OgnlRuntime: Made static ints final.  Use Map.entrySet instead of Map.keySet for better performance.  Javadoc improvements.
> ASTChain: Remove int boxing, lets rely on autoboxing.
> ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
> OgnlOps: use valueOf() instead of new for boxing.  Adjust unnecessary conditional checking.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira