commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pier-Luc Caron St-Pierre (Commented) (JIRA)" <>
Subject [jira] [Commented] (IO-291) Add new function FileUtils.isContained
Date Tue, 08 Nov 2011 02:38:51 GMT


Pier-Luc Caron St-Pierre commented on IO-291:

I build on top of your patch. So if you apply my patch (io-291-v5.patch) from scratch, you
should have our combined changes.

 * I have implemented the directoryContains(final File directory, final File child) 
 * I have added some test case for the newly implemented function.
 * I have Added some javadoc, renamed some parameters
 * I have corrected the code style of the test to match the original style.

We have some issues to address :

 * Actually the test case fail on testSameFile() because the case is tester on a file. It
fail the rule that a directory cannot be a file
 * Does a directory contain itself? I do not have strong opinions about that.
 * Does a file contain itself? I do not have strong opinions about that.
 * In the scope of the method "directoryContains(final File directory, final File child)",
what will happens if the files is an empty collection?
> Add new function FileUtils.isContained
> --------------------------------------
>                 Key: IO-291
>                 URL:
>             Project: Commons IO
>          Issue Type: New Feature
>          Components: Utilities
>    Affects Versions: 2.1
>            Reporter: Pier-Luc Caron St-Pierre
>            Assignee: Gary D. Gregory
>              Labels: patch
>             Fix For: 2.1
>         Attachments: io-291-simple.diff, io-291-v5.patch
> I added a function that determines whether the specified leaf is contains by the specified

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message