commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maurizio Cucchiara (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OGNL-37) [PATCH] Findbugs fixes
Date Thu, 03 Nov 2011 10:07:32 GMT

    [ https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143018#comment-13143018
] 

Maurizio Cucchiara commented on OGNL-37:
----------------------------------------

Once again, thank you Adrian.
I applied your patch with a little exception:
what was
{quote}
ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always
of type String).
{quote}
has become
{quote}
ExpressionCompiler: Corrected attempt to remove LocalReference (keys was always of type String).
{quote}
In fact that was the original behavior of ExpressionCompiler (see at row [699|http://svn.apache.org/viewvc/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/enhance/ExpressionCompiler.java?r1=1187867&r2=1197034&pathrev=1197034&diff_format=h]).

Don't you agree?
                
> [PATCH] Findbugs fixes
> ----------------------
>
>                 Key: OGNL-37
>                 URL: https://issues.apache.org/jira/browse/OGNL-37
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Adrian Cumiskey
>            Priority: Minor
>         Attachments: patch-OGNL37.txt
>
>
> ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
> ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() implementation to override
PropertyDescriptor.
> ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always
of type String).
> ASTMethod: Use StringBuilder instead of String concatenation with '+'.
> DeclaredMethodCacheEntry: Modified equals() implementation to take account of super class
fields.
> OgnlRuntime: Made static ints final.  Use Map.entrySet instead of Map.keySet for better
performance.  Javadoc improvements.
> ASTChain: Remove int boxing, lets rely on autoboxing.
> ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
> OgnlOps: use valueOf() instead of new for boxing.  Adjust unnecessary conditional checking.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message