commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LANG-774) Add isStarted isStopped and isSuspended to StopWatch
Date Sat, 26 Nov 2011 14:55:39 GMT

     [ https://issues.apache.org/jira/browse/LANG-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebb updated LANG-774:
----------------------

    Attachment: LANG774_2.patch

Yes, I think that does look much better. 

But rather than have static enum methods, it might be nicer to have the enums themselves define
their state.

See my alternative patch (based on your enum patch)
                
> Add isStarted isStopped and isSuspended to StopWatch
> ----------------------------------------------------
>
>                 Key: LANG-774
>                 URL: https://issues.apache.org/jira/browse/LANG-774
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.time.*
>    Affects Versions: 3.1
>            Reporter: Michael Akerman
>            Priority: Minor
>              Labels: features
>             Fix For: 3.2
>
>         Attachments: LANG774.diff, LANG774_1.diff, LANG774_2.patch, StopWatch.java
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> It would be nice to have:
>    isStarted
>    isStopped
>    isSuspended
> On StopWatch

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message