commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simone Tripodi (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (DIGESTER-153) Add Constructor support to ObjectCreateRule
Date Fri, 11 Nov 2011 08:38:51 GMT

    [ https://issues.apache.org/jira/browse/DIGESTER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148345#comment-13148345
] 

Simone Tripodi commented on DIGESTER-153:
-----------------------------------------

Amazing contribution Matt, thanks a lot! You are simply the best! :)

The only thing I am currently modifying is avoiding the synchronized block, since each Digester
instance is not thread-safe by definition, so no need to check :)
Moreover we could avoid having the Factory per instance, since the real class has to be instanced
could be defined in one of the XML element attributes.
                
> Add Constructor support to ObjectCreateRule
> -------------------------------------------
>
>                 Key: DIGESTER-153
>                 URL: https://issues.apache.org/jira/browse/DIGESTER-153
>             Project: Commons Digester
>          Issue Type: Improvement
>    Affects Versions: 3.2
>            Reporter: Simone Tripodi
>            Assignee: Simone Tripodi
>             Fix For: 3.2
>
>
> As shown in the past, the stack method of Digester has some [limitations |http://markmail.org/message/wick27gw6n5weqk2]
for fully support the Constructors - it basically cannot use elements in the body as constructor
arguments - but it could support arguments extracted from attributes. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message