commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Holger S. (Commented) (JIRA)" <>
Subject [jira] [Commented] (CLI-120) equals and hashCode are incomplete
Date Sun, 13 Nov 2011 16:39:51 GMT


Holger S. commented on CLI-120:

I would like to implement the equals method for a few classes. 

I suggest to implement the methods strightforwardly by calling .equals on all members (or
using == if primitive) and returning the ANDed result.
Are there any classes where this approach might fail?

Is it possible to implement the hashCode method for the other classes like in OptionImpl?
I am not experienced in implementing hashCode so I am not sure, whether that approach is possible
for all classes.

This is a part of a lecture assignment, so I would be very grateful for quick responses :-)

> equals and hashCode are incomplete
> ----------------------------------
>                 Key: CLI-120
>                 URL:
>             Project: Commons CLI
>          Issue Type: Improvement
>          Components: CLI-2.x
>            Reporter: Andrew Shirley
>            Priority: Minor
>             Fix For: 2.0
> there are many classes with equals and hashCode implemented however there are also classes
which don't. We need to be consistent and if we are using equals then we need to define it
for all classes in the affected hierarchy. For example OptionImpl has an equals but ParentImpl
which extends OptionImpl and has several new members doesn't.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message