commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrian Cumiskey (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (OGNL-37) [PATCH] Findbugs fixes
Date Thu, 03 Nov 2011 06:41:32 GMT
[PATCH] Findbugs fixes
----------------------

                 Key: OGNL-37
                 URL: https://issues.apache.org/jira/browse/OGNL-37
             Project: OGNL
          Issue Type: Improvement
            Reporter: Adrian Cumiskey
            Priority: Minor


ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
ObjectIndexedPropertyDescriptor: Provide equals() and hashcode() implementation to override
PropertyDescriptor.
ExpressionCompiler: Remove redundant attempt to remove LocalReference key (keys are always
of type String).
ASTMethod: Use StringBuilder instead of String concatenation with '+'.
DeclaredMethodCacheEntry: Modified equals() implementation to take account of super class
fields.
OgnlRuntime: Made static ints final.  Use Map.entrySet instead of Map.keySet for better performance.
 Javadoc improvements.
ASTChain: Remove int boxing, lets rely on autoboxing.
ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
OgnlOps: use valueOf() instead of new for boxing.  Adjust unnecessary conditional checking.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message