commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary D. Gregory (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (VFS-396) RAM FileSystem allows the file system size to exceed the max size limit.
Date Sun, 27 Nov 2011 21:48:40 GMT

    [ https://issues.apache.org/jira/browse/VFS-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158036#comment-13158036
] 

Gary D. Gregory commented on VFS-396:
-------------------------------------

Can you provide a patch with a unit test please?

-- Posted from Bugbox for iPhone
                
> RAM FileSystem allows the file system size to exceed the max size limit.
> ------------------------------------------------------------------------
>
>                 Key: VFS-396
>                 URL: https://issues.apache.org/jira/browse/VFS-396
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>         Environment: All
>            Reporter: Rupesh Kumar
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> When a new file is created in the RAM file system, and content is written to its outputstream,
there is a check in place for ensuring that file system size does not exceed the max limit
set. But that check is wrong.
> In RamFileOutputStream.write(), you calculate the size, newsize and call file.resize(newSize)
> And in the RamFileObject.resize(), there is a check 
>  if (fs.size() + newSize - this.size() > maxSize)
>             {
>                 throw new IOException("FileSystem capacity (" + maxSize
>                         + ") exceeded.");
>             }
> This check is wrong. 
> Consider this case of a new file system where the file system size is set to 5 MB and
I am trying to create a file of 10 MB in the RAM file system. the file is being written in
the chunk of 8 kb. For every resize check, fs.size() would be 0 and (newsize - this.size())
would be 8 kb and therefore the check never passes.
>  It could have been correct if the "old size" was locked down to the size that was registered
with the file system but the old size (this.size()) keeps changing at every write. Thus the
difference in newSize and this.size() would always be the chunk size (typically 8 kb) and
therefore no exception would be thrown ever.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message