commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William R. Speirs (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (POOL-189) close() does not release threads blocked on borrowObject()
Date Mon, 21 Nov 2011 15:18:52 GMT

    [ https://issues.apache.org/jira/browse/POOL-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154238#comment-13154238
] 

William R. Speirs commented on POOL-189:
----------------------------------------

Wondering how the performance tests are coming along?

A thought. I wouldn't be surprised if the if(...) check does take a bit longer, but does it
really matter? The thread has already been asleep waiting on the pool to grow. I would say
argue that performing the check to see if the pool has been closed is simply "part of growing
the pool". Thoughts?
                
> close() does not release threads blocked on borrowObject()
> ----------------------------------------------------------
>
>                 Key: POOL-189
>                 URL: https://issues.apache.org/jira/browse/POOL-189
>             Project: Commons Pool
>          Issue Type: Bug
>    Affects Versions: 1.5.6
>         Environment: java 1.6.0_24
>            Reporter: Adrian Nistor
>             Fix For: 1.5.7
>
>         Attachments: BUG-189v1.diff, BUG-189v2.diff, Test.java
>
>
> Hi,
> When I call close() and borrowObject() concurrently with no objects in
> the pool, close() will finish but borrowObject() is blocked forever.
> The documentation of close() mentions that borrowObject() should fail 
> with IllegalStateException, so I would expect the waiting threads to 
> throw IllegalStateException.
> I will attach a test that exposes this problem. For this test, the 
> expected output is:
> 0
> 1
> 2
> ...
> 4999
> DONE
> But when the bug manifests (almost always for this test), the output 
> is:
> 0
> 1
> 2
> The test does not finish, it just gets stuck after printing several 
> values.
> Is this a bug or am I reading the documentation wrongly? Is there 
> a patch for this?
> Thanks!
> Adrian

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message